add CI job for prototype tests#4664
Conversation
|
CI job is operational: https://app.circleci.com/pipelines/github/pytorch/vision/11516/workflows/d46b293b-a579-4d84-ac55-062bd4a815ab/jobs/894445 I'll fix the warnings in a follow-up PR. |
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
Nice, LGTM! We can merge after green CI.
| --ignore=test/test_datasets_download.py | ||
| --ignore-glob=test/test_prototype_*.py |
There was a problem hiding this comment.
Unless we invoke pytest specifically with test/test_prototype_*.py, the prototype tests will now be ignored for the normal unittests.
I've applied the same treatment to the dataset download tests. With this, invoking pytest locally is now exactly the same as in CI minus the coverage. LMK if I should split this in a separate PR.
There was a problem hiding this comment.
Looks good. Personally I'm happy to keep it here.
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * add CI job for prototype tests * register prototype job * fix torchvision installation * fix test invocation * ignore prototype tests in normal unittests Reviewed By: datumbox Differential Revision: D31898205 fbshipit-source-id: 3fcde83a5f6dceaa21d2572fb21d78348a842b9b Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
* add CI job for prototype tests * register prototype job * fix torchvision installation * fix test invocation * ignore prototype tests in normal unittests Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
4 participants
Closes #4589.
cc @pmeier @seemethere @bjuncek